On Mon, 5 Oct 2026 18:43:08 GMT, Marius Hanl <[email protected]> wrote:

> This was found in 
> [JDK-8365309](https://bugs.openjdk.org/browse/JDK-8365309)(https://github.com/openjdk/jfx/pull/2299)
>  and is also closely related, as solving this issue here makes life easier to 
> solve the refactoring in that PR in a clean way.
> 
> `TitledPaneSkin` is the only `Control` (Skin) that caches the `Node` via 
> `setCache`, only for embedded devices.
> 
> I propose to remove it.
> Because:
> - Other `Control` (Skin)s do not have this special treatment
> - Embedded check is not a real indicator how powerful a device is
> - Currently, when the animation is cancelled the `setCache(false)` may never 
> run, making the flag permanent
> - Since [JDK-8385459](https://bugs.openjdk.org/browse/JDK-8385459), we will 
> respect the `reducedMotion` user preference. This can be easily used to 
> disable all animations, including the `TitledPane` one
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Looks good, as I commented earlier, I see no issues with removing this legacy 
check.

-------------

Marked as reviewed by jhendrikx (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/2336#pullrequestreview-5430298516

Reply via email to