On Thu, 1 Oct 2026 21:27:00 GMT, Michael Strauß <[email protected]> wrote:

>> Martin Fox has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Fixed some bugs in how window flags are set up.
>
> modules/javafx.graphics/src/main/java/javafx/stage/StageBackdropStyle.java 
> line 145:
> 
>> 143:      * @return the optional backdrop style
>> 144:      */
>> 145:     public static Optional<StageBackdropStyle> style(String name) {
> 
> Some alternatives for consideration: `ofNamed`, `ofPlatformName`

I looked at some existing factory methods and in general their names are nouns 
describing (roughly) what the method produces. Examples include 
`Duration.seconds` and `Font.font`. So I went with `style` to match that 
convention.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2048#discussion_r4197640293

Reply via email to