On Thu, 1 Oct 2026 20:43:13 GMT, Michael Strauß <[email protected]> wrote:
>> Martin Fox has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed some bugs in how window flags are set up.
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/mac/MacWindow.java
> line 253:
>
>> 251: }
>> 252:
>> 253: private static Map<String, Integer> backdropStyles = null;
>
> You could initialize the style map directly, which would remove the need to
> call `initBackdropStyles()` in several places:
>
> Suggestion:
>
> private static final Map<String, Integer> backdropStyles = Map.ofEntries(
> Map.entry("macOS.HUD", BackdropID.HUD),
> Map.entry("macOS.Menu", BackdropID.MENU),
> Map.entry("macOS.Popover", BackdropID.POPOVER),
> Map.entry("macOS.Tooltip", BackdropID.TOOLTIP)
> );
I updated this initialization code. We could use a hard-coded list right now
but support for `macOS.ClearGlass` requires some conditional checks so a
hard-coded list won't work. `macOS.ClearGlass` is disabled until we have access
to the macOS 26 SDK on the build machines.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2048#discussion_r4197745299
