On Wed, 7 Oct 2026 15:29:32 GMT, Andy Goryachev <[email protected]> wrote:

>> yes, same thought. Shall I do in this PR? Otherwise I will create a ticket 
>> and clean it up afterwards.
>
> The usual argument for unrelated changes is to make them in a separate PR for 
> the sake or reviewers and backporters, but if we are touching this code we 
> might as well clean it up.

This pattern was [deliberately 
introduced](https://github.com/openjdk/jfx/pull/1608#discussion_r1819938688) so 
that static constants can be initialized from an expression. The alternative, 
stuffing unrelated initialization code into a static initializer, or having a 
static initialization method, has its downsides.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2299#discussion_r4221544154

Reply via email to