On Thu, 8 Oct 2026 16:04:39 GMT, Ziad El Midaoui <[email protected]> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains eight additional >> commits since the last revision: >> >> - new scripts >> - Merge branch 'master' into 8382094.monkey >> - update >> - Merge branch 'master' into 8382094.monkey >> - rm leftovers >> - Merge branch 'master' into 8382094.monkey >> - whitespace >> - monkey tester upd 8 > > I tested the changes introduced in the PR and mostly look good other than > some issues I noticed : > > 1. `RichTextArea` accepts image drops when editing is disabled. > Unchecking editable prevents typing, but dragging an image file into the > editor still insert it. I tested this behavior in master and it is blocked > when editing is disabled. > > 2. Shape loses the selected dash pattern when any other property changes. > - Select Shape -> choose a rectangle -> Dash Array value ([2] or [3,5]) -> > notice the dashed outline -> change width (as an example) -> the outline > become solid again , this can happen when changing any other property > > 3. The Stage "Hide stage" button label is not reset when window is closed > using the close button and not the "hide stage" button , to test it select > Stage -> click "show stage" button -> close the window with the "x" close > button -> the button label is still showing as "hide stage" > > Not sure if these are actually the expected behaviors, but they are different > than what is in the master branch. Good catch, @Ziad-Mid ! Thankfully, all three are the monkey tester problem, though the first issue has a sibling in the `RichEditorDemo`, I've filed https://bugs.openjdk.org/browse/JDK-8393970 . ------------- PR Comment: https://git.openjdk.org/jfx/pull/2302#issuecomment-6066179967
