On Tue, 13 Oct 2026 13:10:03 GMT, Lukasz Kostyra <[email protected]> wrote:
> I think invalidating the flag in `setDeviceParametersFor3D` (which is what > this PR does) should be enough for this case? In "3D draw -> Failed 2D draw but successful D3DShader.setConstantsF() -> again 3D draw" scenario `setDeviceParametersFor3D` will not be called again and light cache flag will not be invalidated. Example of 2D draw call which can set external shader, but return without draw if source texture is not set properly: https://github.com/openjdk/jfx/blob/master/modules/javafx.graphics/src/main/java/com/sun/scenario/effect/impl/prism/ps/PPSOneSamplerPeer.java#L56. In this case second 3D draw will have improper light constant details. ------------- PR Comment: https://git.openjdk.org/jfx/pull/2319#issuecomment-6164791350
