On Mon, 19 Oct 2026 19:19:25 GMT, Andy Goryachev <[email protected]> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add missing since tags
>
> modules/javafx.graphics/src/main/java/com/sun/prism/sw/SWDrawingContext.java
> line 731:
>
>> 729: graphics.setPaint(prismFillPaint);
>> 730: graphics.resetPaintBounds();
>> 731: graphics.fillRect((float)x, (float)y, (float)w, (float)h);
>
> `fillRect()` uses `PiscesRenderer.fillRect()` which will overflow with wide /
> tall images due to `<< 16`. Should it tile or explicitly call for
> width/height limitations in the constructor?
This is a pre-existing limitation also for Canvas under the SW pipeline (where
it fails just as silently). I think this is better addressed separately as a
solution may be involved.
> modules/javafx.graphics/src/main/java/com/sun/prism/sw/SWDrawingContext.java
> line 775:
>
>> 773: public void fillOval(double x, double y, double w, double h) {
>> 774: if (w != 0 && h != 0) {
>> 775: applyStrokeParameters();
>
> are stroke parameters needed for the fill operation?
No, removed it.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1969#discussion_r4321245309
PR Review Comment: https://git.openjdk.org/jfx/pull/1969#discussion_r4321229463
