On Wed, 21 Oct 2026 18:37:14 GMT, Andy Goryachev <[email protected]> wrote:
>> John Hendrikx has updated the pull request incrementally with eight
>> additional commits since the last revision:
>>
>> - Add fast no copy draw path for heap backed INT_ARGB images
>> - Document image size limitations
>> - Add test for malformed polygon data
>> - Fix new and pre-existing issue in JJavaSurface.c
>> - Document and align behavior when not enough points supplied for polygon
>> - Documented strokes/fills degenerate cases and made them consistent
>> - Add missing table entry for GraphicsContext
>> - Fix copyright year after botched merge
>
> modules/javafx.graphics/src/main/java/com/sun/prism/sw/SWDrawingContext.java
> line 272:
>
>> 270: @Override
>> 271: public void run() {
>> 272: texture.dispose();
>
> `SWRTTexture.dispose()` is a no-op. Are you sure all the native resources
> will be cleaned up?
There are no native resources for a software texture. It does point to the data
of the `WritableImage`, but that may outlive the `DrawingContext`, so even if
we could clean it up immediately, the largest chunk (the image) would still
live on as `WritableImage` refers it. So the `dipose` being empty is correct
for this kind of texture.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1969#discussion_r4341360781
