On Fri, 23 Oct 2026 16:33:58 GMT, Andy Goryachev <[email protected]> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Allow INT_ARGB_PRE format for icons > > modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/WindowStage.java > line 402: > >> 400: im.getPixelFormat() == PixelFormat.BYTE_BGRA_PRE || >> 401: im.getPixelFormat() == PixelFormat.BYTE_GRAY || >> 402: im.getPixelFormat() == PixelFormat.INT_ARGB_PRE)) > > would a `switch` statement be better now? I think it's fine, we're not really doing different behaviors per branch here and no need to rewrite things that work fine. I likely wouldn't have used a `switch` here even if I wrote it today. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1969#discussion_r4363881137
