On Tue, 27 Oct 2026 15:56:15 GMT, Andy Goryachev <[email protected]> wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8389211: Fix HLS Live issues found during testing of JDK-8331458 and
>> various live streams [v5]
>
> modules/javafx.media/src/main/java/com/sun/media/jfxmedia/locator/HLSConnectionHolder.java
> line 230:
>
>> 228: public void closeConnection() {
>> 229: if (currentPlaylist != null) {
>> 230: currentPlaylist.close();
>
> should the reference be null'd?
also, is it possible that one of these methods will throw and the holder enters
an inconsistent state?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2227#discussion_r4390985975
