On Tue, 27 Oct 2026 15:58:21 GMT, Andy Goryachev <[email protected]> wrote:
>> modules/javafx.media/src/main/java/com/sun/media/jfxmedia/locator/HLSConnectionHolder.java
>> line 230:
>>
>>> 228: public void closeConnection() {
>>> 229: if (currentPlaylist != null) {
>>> 230: currentPlaylist.close();
>>
>> should the reference be null'd?
>
> also, is it possible that one of these methods will throw and the holder
> enters an inconsistent state?
No need to null it. It will break other code. It might be possible for
unchecked exceptions. I will use try/finally to close connection.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2227#discussion_r4395622342
