On Mon, 9 Nov 2026 19:55:12 GMT, Alexander Zuev <[email protected]> wrote:
>> modules/javafx.graphics/src/main/java/com/sun/glass/ui/mac/MacAccessible.java >> line 888: >> >>> 886: continue; >>> 887: } >>> 888: accessible.getNativeAccessible(); >> >> Is this needed? Looks weird as a standalone code snippet. Might ne a comment >> that explain that this has an intended side effect we need? > > Yes and it is stated in the beginning of the method documentation: > "Initializes descendant peers". A side effect of the original native code > that we have to preserve to make sure VO correctly enumerates children in the > menu popup. I see. But I wonder if we still want to write a small comment above with something like `We must initialize the accessible` or something similar. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2360#discussion_r4517558567
