On Mon, 9 Nov 2026 20:23:11 GMT, Marius Hanl <[email protected]> wrote:

>> Yes and it is stated in the beginning of the method documentation: 
>> "Initializes descendant peers". A side effect of the original native code 
>> that we have to preserve to make sure VO correctly enumerates children in 
>> the menu popup.
>
> I see. But I wonder if we still want to write a small comment above with 
> something like `We must initialize the accessible` or something similar.

Ok, i added the comment. But that is one more reason - aside of just locking in 
the way we implement the children traversal - to not to extract this logic into 
some service method because if we do in the future someone will absolutely 
reuse it for something else and this preserved side effect will backfire. So as 
much as i am for the easy readability of the code - this is a very specific 
case and i want it to be self-contained.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2360#discussion_r4518401408

Reply via email to