On Thu, 12 Nov 2026 20:17:53 GMT, Marius Hanl <[email protected]> wrote:

>> modules/javafx.graphics/src/main/java/javafx/scene/CssStyleHelper.java line 
>> 960:
>> 
>>> 958:             Entry<CssMetaData, CalculatedValue> entry = it.next();
>>> 959:             CssMetaData cssMetaData = entry.getKey();
>>> 960:             if (cssMetaData != 
>>> TransitionDefinitionCssMetaData.getInstance() && 
>>> !styleables.contains(cssMetaData)) {
>> 
>> unlikely but legitimate scenario: when a custom skin provides a different 
>> metadata for the same control property.  this check seems to discard the 
>> original reset entry.
>
> I reverted this to the previous behavior.
> 
> I don't think this corner case is worth the effort right now. It's a pretty 
> unusual API scenario, so I'd rather not address it here and keep the scope on 
> the main use case. We can come back to it if it turns out to matter in 
> practice.

I think this is reasonable, and reverting it is definitely better than leaving 
this in, which could cause other problems (not just the NPE Andy pointed out).

Can you file a follow-up bug? P4 is probably fine for this case. That way you 
can use the Bug ID in the `@Diabled` annotation.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2366#discussion_r4556863131

Reply via email to