> This PR is a mix between fixing the regression and fixing the actual root 
> cause of it.
> 
> #### Starting with the regression:
> 
> 1. When a `Tooltip` is shown again, `applyCss()` is called before showing it 
> (So we can resolve the `-fx-show-delay`). 
> That pass used the stale helper, leading to broken CSS (reset).
> 2. The `CssStyleHelper.resetProperties` now walks all the 
> `CssStyleHelper.cssSetProperties`, including metadata the node no longer has, 
> for example after its skin was removed. This can lead to a wrong reset or NPE.
> 
> #### Preexisting bugs (root causes):
> 
> 3. `Window.hide()` and `Window.setScene()` drop the scene CSS cache (-> 
> `forget()`), but the nodes keep their old style helpers.
> Applying CSS before the window is shown again styled the node with 
> `StyleMap.EMPTY_MAP` because of the stale helper.
> 
> This is the root cause of the issue, which before worked by accident (due to 
> the inherit).
> 
> 4. `CssStyleHelper.resetToInitialValues` always reset every tracked property, 
> removed skin metadata included, with the same NPE or wrong reset.
> 
> Root cause: This was never right and I accidentally made it worse by doing 
> the same in the `transitionToState` reset as we did in 
> `resetToInitialValues`. ~We now remove stale entries.~ Reverted to the 
> previous behavior. See comment below inline.
> 
> #### Related, also fixed by accident:
> 
> 5. `scheduleReapplyCSS()` set `REAPPLY` without marking the root `NODE_CSS` 
> dirty, so `applyCss()` on a child skipped the root and only saw the change 
> after the next pulse. 
> Fix is to call `notifyParentsOfInvalidatedCSS()` after. Found because I'm 
> reusing this method now for the fix.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Marius Hanl has updated the pull request incrementally with one additional 
commit since the last revision:

  JDK-8397428 on @Disabled

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/2366/files
  - new: https://git.openjdk.org/jfx/pull/2366/files/2c09449d..c1139621

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=2366&range=02
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=2366&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jfx/pull/2366.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/2366/head:pull/2366

PR: https://git.openjdk.org/jfx/pull/2366

Reply via email to