Review: Needs Fixing

I don't see the point in your DuplicateSongFinder class. You could quite easily 
make those methods into functions, and your constant object attributes into 
constants, and skip the memory overhead of the class + object.

This is Python, we don't need classes everywhere :-)

Ping me in IRC if you need any help/guidance/direction/etc.
-- 
https://code.launchpad.net/~patrick-zakweb/openlp/duplicate-removal-review/+merge/149130
Your team OpenLP Core is subscribed to branch lp:openlp.

_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to     : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

Reply via email to