Review: Needs Fixing 38-40 having two nots is not simple to read and does not explain what you are trying to block. An New Capability may be easier! 82-88 you are exposing internal workings of the service item in the plugins try and put this in the service item and use the registry to get the plurals if necessary. 8-9 have a start for this. You may be able to simplify the code in the plugin as well. 56-62 commented out please remove or fix. -- https://code.launchpad.net/~marmyshev/openlp/item_title/+merge/156694 Your team OpenLP Core is subscribed to branch lp:openlp.
_______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
