OK, your changes in that revision to
opennms-webapp/src/main/webapp/WEB-INF/dispatcher-servlet.xml are
identical to mine that I committed to 1.10 except that your edits have
some double- and triple-duplicated lines for the
AnnotationMethodHandlerAdapter and DefaultAnnotationHandlerMapping bean
definitions for some reason. My changes were pushed to sf.net yesterday,
not sure if Ben has had a chance to merge to 1.11 (master) yet.
I'll hold off on any further changes until we can coordinate but I don't
think we've stepped on each others' toes too badly so far. :) Looks like
good work! I'm looking forward to see some of these controllers get
simplified with annotations.
-- Seth
On 07/28/2011 07:21 PM, DJ Gregor wrote:
> Hey Seth,
>
> Did you push your changes to sf.net? Into which branch? I pushed Melania's
> support for controller annotations to master on sf.net on 7/22 along with the
> conversion of element/service.jsp (commit
> 3b378424bcb15de58359669ce09fde51ce91152f). I want to make sure we aren't
> stepping on each other's toes and that we try to keep things synced between
> different branches except when it doesn't make sense. Also, since Melania is
> converting JSPs and servlets to use Hibernate, I want to make sure we aren't
> stepping on each others toes there, either.
>
> On Jul 28, 2011, at 5:03 PM, Seth Leger <s...@opennms.org> wrote:
>
>
>> Hi Melania,
>>
>> I happened to be looking at the Spring annotation-based servlets today. I
>> committed a change that should allow us to start using @Controller and
>> @RequestMapping attributes to map Spring servlets into the webapp. The only
>> examples in our current codebase of this are very simple cases:
>>
>> opennms-webapp/src/main/java/org/opennms/web/controller/FrontPageController.java
>> opennms-webapp/src/main/java/org/opennms/web/controller/CategoryStatusController.java
>>
>> Now that the dispatcher-servlet.xml context has been updated to support the
>> @RequestMapping annotations, it should be easy to start moving legacy Spring
>> MVC servlets over to the new annotation-based conventions. The first
>> priority for me is to move all of the servlets that inherit from
>> org.springframework.web.servlet.mvc.SimpleFormController since it was
>> deprecated in Spring 3.0 specifically in favor of using annotations for your
>> controllers.
>>
>> Please let us know on this opennms-devel list if you have any questions
>> about this work! It will be great to move the code over to annotations: it
>> will make the controller code simpler and much easier to read and maintain.
>> Thanks!
>>
>> Seth Leger
>> The OpenNMS Group
>>
>>
>> On 07/28/2011 01:42 PM, Melania Galea wrote:
>>
>>> I am Melania. My google summer of code target is to finish converting the
>>> OpenNMS GUI pages to Hibernate. For the UI layer refactoring process, the
>>> SpringMVC web framework was chosen, which due to its underlying MVC design
>>> pattern offers the possibility to build flexible and loosely coupled
>>> applications. My mentor and I have managed to create a design for the
>>> controllers which are meant to process the requests and display a response.
>>> The controller classes are using annotations and autowired dependency
>>> injection which leaves out the burden of the xml configuration. They are
>>> also easily to be unit tested directly. All the logic regarding the requests
>>> is contained by the controllers since now a Hibernate session is
>>> automatically opened for all web requests. There will be no need for a
>>> separate service layer that handles the database queries. I have built a
>>> wiki page which will be more explanatory regarding the above topics.
>>>
>>> http://opennms.org/wiki/Annotation_Driven_Controllers
>>>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Got Input? Slashdot Needs You.
>>> Take our quick survey online. Come on, we don't ask for help often.
>>> Plus, you'll get a chance to win $100 to spend on ThinkGeek.
>>> http://p.sf.net/sfu/slashdot-survey
>>>
>>> _______________________________________________
>>> Please read the OpenNMS Mailing List FAQ:
>>> http://www.opennms.org/index.php/Mailing_List_FAQ
>>>
>>> opennms-devel mailing list
>>>
>>> To *unsubscribe* or change your subscription options, see the bottom of
>>> this page:
>>> https://lists.sourceforge.net/lists/listinfo/opennms-devel
>>>
>> ------------------------------------------------------------------------------
>> Got Input? Slashdot Needs You.
>> Take our quick survey online. Come on, we don't ask for help often.
>> Plus, you'll get a chance to win $100 to spend on ThinkGeek.
>> http://p.sf.net/sfu/slashdot-survey
>> _______________________________________________
>> Please read the OpenNMS Mailing List FAQ:
>> http://www.opennms.org/index.php/Mailing_List_FAQ
>>
>> opennms-devel mailing list
>>
>> To *unsubscribe* or change your subscription options, see the bottom of this
>> page:
>> https://lists.sourceforge.net/lists/listinfo/opennms-devel
>>
>
>
>
> ------------------------------------------------------------------------------
> Got Input? Slashdot Needs You.
> Take our quick survey online. Come on, we don't ask for help often.
> Plus, you'll get a chance to win $100 to spend on ThinkGeek.
> http://p.sf.net/sfu/slashdot-survey
>
>
> _______________________________________________
> Please read the OpenNMS Mailing List FAQ:
> http://www.opennms.org/index.php/Mailing_List_FAQ
>
> opennms-devel mailing list
>
> To *unsubscribe* or change your subscription options, see the bottom of this
> page:
> https://lists.sourceforge.net/lists/listinfo/opennms-devel
------------------------------------------------------------------------------
Got Input? Slashdot Needs You.
Take our quick survey online. Come on, we don't ask for help often.
Plus, you'll get a chance to win $100 to spend on ThinkGeek.
http://p.sf.net/sfu/slashdot-survey
_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/index.php/Mailing_List_FAQ
opennms-devel mailing list
To *unsubscribe* or change your subscription options, see the bottom of this
page:
https://lists.sourceforge.net/lists/listinfo/opennms-devel
