Update! I did: git reset --hard HEAD git clean -f -d -x rebuilt / reassembled and then the changes I was making made it into the deployment tarball. So maybe there's an issue with the build somewhere, but at least I can make progress.
On Fri, Jan 9, 2015 at 4:13 PM, David Schlenk <david.schl...@spanlink.com> wrote: > I thought I'd give fixing NMS-3615 a go since it's handy to have and > has been broken for a while now. I'm new to GWT so my approach might > be less than optimal, but regardless I'm having a heck of a time > actually getting what I think I've done to even begin to work (or not > work). Let me explain: > > NMS-3615 basically chronicles the broken then fixed then broken again > feature of letting you graph data points in resources that don't have > predefined graphs written for them. When the ExtJS implementation of > selecting resources was rewritten in GWT it broke. You can make it > work by replacing results.htm with adhoc2.jsp in the URL after you > pick a resource. > > So clearly it's just a page sequence issue, can't be that hard, right? > First step seemed to be getting the endUrl parameter passing > graph/adhoc2.jsp when you click on a resource to start the process, so > I did: > https://github.com/dschlenk/opennms/commit/a5a43a6a7e1ff080bc38fcb87cf9caff8b167aee > After ../../compile.pl install in features/gwt-graph-resource-list and > ../compile.pl in opennms-webapp followed by assemble.pl, this actually > does what I expect! Now when I pick a node from the Custom Resource > Performance Reports box the URL on the next page includes > &endUrl=graph%2Fadhoc2.jsp. > > Next thing is to make this rendered page care about the endUrl > parameter being there. If I understand correctly, this page is > rendered from ChooseResourceController which ultimately feeds > opennms-webapp/src/webapp/WEB-INF/jsp/graph/chooseresource.jsp, which > from what I understand uses the same GWT entry point that I changed to > make the first part work since it contains these elements: > > <opennms:reportSelectionList id="choose-resource" > dataObject="data"></opennms:reportSelectionList> > <!-- for IE --><div name="opennms-reportSelectionList" > id="choose-resource-ie" dataObject="data"></div> > > So I added some code to the reportSelectionList handling bits to check > for the endUrl parameter in Window.Location. That didn't work, so I > started adding Window.alert calls in various places, which also don't > work, and then I did all sorts of other things to try to get > *something* to happen. No luck. Am I in the wrong spot, or is there > something else I need to do to get my changes to deploy properly? Or > am I just not able to make client calls like > Window.Location.getParameter and Window.alert where I'm doing them? > > I guess I could go to a different location entirely and use a similar > approach as I did in the first part - making an entirely separate > component. > > Any other ideas? > > Thanks! > -- > David Schlenk -- David Schlenk Manager, Research & Development T: 763.971.2030 | Video/Email: david.schl...@spanlink.com ConvergeOne Collaboration, formerly Spanlink Communications New name, but same great people and Cisco focus. > Learn more PLEASE NOTE: My email address is changing Nov. 1 to dschl...@converge-one.com ------------------------------------------------------------------------------ Dive into the World of Parallel Programming! The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net _______________________________________________ Please read the OpenNMS Mailing List FAQ: http://www.opennms.org/index.php/Mailing_List_FAQ opennms-devel mailing list To *unsubscribe* or change your subscription options, see the bottom of this page: https://lists.sourceforge.net/lists/listinfo/opennms-devel
