Hi Alex,
> >> I have updated the netbuf reimplementation patch so that it applies
> >> cleanly to the CVS. I've done some testing with USB and obex_test and it
> >> seems to work. But of course more testing is needed, so please do that.
> >
> > I really like to apply this patch, but the coding style is totally
> > wrong. We don't use Java like function naming.
> >
> > Maybe using buf_t as type and buf_ as function prefix would be the best
> > way to clean this up.
>
> I've done a new patch as you suggested. Is this better?
we should change things like "buf_reservebegin" to "buf_reserve_begin"
to make it more readable.
A small coding style thing. Please put the "{" for functions on the next
line.
Do we need the slist thing to be a separate file? I think it can go into
databuffer.c as static function.
And there is no need to include the removal of netbuf.[ch]. I will do
that directly in the CVS when I commit the patch.
Other comments please, but I think it looks good.
Regards
Marcel
-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Openobex-users mailing list
[email protected]
http://lists.sourceforge.net/lists/listinfo/openobex-users
