Hi Alex,
> > Do we need the slist thing to be a separate file? I think it can go into
> > databuffer.c as static function.
>
> slist is used in other files too, so it's now in databuffer.c but not as
> static.
ah, yes, my bad. But keeping it in databuffer.[ch] looks better to me.
> > Other comments please, but I think it looks good.
>
> Check the attachment with all the fixes.
The slist_remove() should do "if (!list) return NULL". This save an
indentation and make it more readable.
In buf_new() the label is not needed. It is fine to use "return NULL" in
both cases.
The buf_total_size() missed a check for p.
In buf_resize() we can use direkt return instead of the label. For
exmaple "if (!p) return".
For buf_reuse() and buf_free() use "if (!p) return".
And of course all "} else {" must be on the same line.
Regards
Marcel
-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Openobex-users mailing list
[email protected]
http://lists.sourceforge.net/lists/listinfo/openobex-users
