This is an automated email from Gerrit.
Paul Fertser (fercer...@gmail.com) just uploaded a new patch set to Gerrit,
which you can find at http://openocd.zylin.com/1615
-- gerrit
commit d9e0c9cfcaab62d31303ffd6dabfbe9b29a5d4bc
Author: Paul Fertser <fercer...@gmail.com>
Date: Tue Sep 10 15:14:56 2013 +0400
svf: off-by-one error; do not access after the allocated memory
Keep the promise and ensure there're at least 3 bytes available after
the current position.
This eliminates the errors reported by Valgrind.
Change-Id: I1d0640e904c750eed808b2b4caf419b4d7619845
Signed-off-by: Paul Fertser <fercer...@gmail.com>
diff --git a/src/svf/svf.c b/src/svf/svf.c
index 69f75ac..3e7bfbf 100644
--- a/src/svf/svf.c
+++ b/src/svf/svf.c
@@ -642,8 +642,9 @@ static int svf_read_command_from_file(FILE *fd)
* - added space.
* - terminating NUL ('\0')
*/
- if ((cmd_pos + 2) >= svf_command_buffer_size) {
- svf_command_buffer =
realloc(svf_command_buffer, (cmd_pos + 2));
+ if (cmd_pos + 3 > svf_command_buffer_size) {
+ svf_command_buffer =
realloc(svf_command_buffer, cmd_pos + 3);
+ svf_command_buffer_size = cmd_pos + 3;
if (svf_command_buffer == NULL) {
LOG_ERROR("not enough memory");
return ERROR_FAIL;
--
------------------------------------------------------------------------------
How ServiceNow helps IT people transform IT departments:
1. Consolidate legacy IT systems to a single system of record for IT
2. Standardize and globalize service processes across IT
3. Implement zero-touch automation to replace manual, redundant tasks
http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk
_______________________________________________
OpenOCD-devel mailing list
OpenOCD-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openocd-devel
