On Thu, Oct 30, 2014 at 7:58 AM, <ger...@openocd.zylin.com> wrote: > This is an automated email from Gerrit. > > Jim Paris (j...@jtan.com) just uploaded a new patch set to Gerrit, which you > can find at http://openocd.zylin.com/2366 > > -- gerrit > > commit 7f586ef1901eb7f061974f4693bb34a968982596 > Author: Jim Paris <j...@jtan.com> > Date: Wed Oct 29 19:09:49 2014 -0400 > > nrf51: fix checks for is_erased > > is_erased can take the value 0 (no), 1 (yes), or -1 (unknown). > Checks like (!is_erased) don't do the right thing if it's -1.
Good catch! On that topic, it bothers me when "is_foo" variables are used that way, though it's probably way too invasive to rename it at this point. The 0, 1, or -1 reminds me of http://thedailywtf.com/articles/What_Is_Truth_0x3f_ ------------------------------------------------------------------------------ _______________________________________________ OpenOCD-devel mailing list OpenOCD-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openocd-devel
