This is an automated email from Gerrit.
Andrey Yurovsky (yurov...@gmail.com) just uploaded a new patch set to Gerrit,
which you can find at http://openocd.zylin.com/2368
-- gerrit
commit 8c4a77743fa85a6c2f94c3ca0d9d451fe76ce956
Author: Andrey Yurovsky <yurov...@gmail.com>
Date: Thu Oct 30 11:56:08 2014 -0700
flash: at91samd: fix use of is_erased in check
is_erased can be one of -1, 0, or 1 so it must not be checked like a
boolean value. In this case we want to erase a page unless we know it's
already erased so we just check for is_erased != 1.
Thanks to Jim Paris for pointing this out on another driver.
Change-Id: I4591186228153b64e5a9608a2aac18745e578d4a
Signed-off-by: Andrey Yurovsky <yurov...@gmail.com>
diff --git a/src/flash/nor/at91samd.c b/src/flash/nor/at91samd.c
index 7c877c0..ece1fd2 100644
--- a/src/flash/nor/at91samd.c
+++ b/src/flash/nor/at91samd.c
@@ -590,7 +590,7 @@ static int samd_erase(struct flash_bank *bank, int first,
int last)
return ERROR_FLASH_OPERATION_FAILED;
}
- if (!bank->sectors[s].is_erased) {
+ if (bank->sectors[s].is_erased != 1) {
/* For each row in that sector */
for (int r = s * rows_in_sector; r < (s + 1) *
rows_in_sector; r++) {
res = samd_erase_row(bank->target, r *
chip->page_size * 4);
--
------------------------------------------------------------------------------
_______________________________________________
OpenOCD-devel mailing list
OpenOCD-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openocd-devel
