> -----Original Message----- > From: vichy [mailto:vichy....@gmail.com] > Sent: Sunday, February 01, 2015 10:44 AM > To: David Ung > Cc: openocd-devel@lists.sourceforge.net; Paul Fertser > Subject: Re: about armv8 64 bits support > > hi David: > > > > Use "git push review", it should make your new commits dependent on > > the ones I've already posted. > > > > David > > > I update what I modify so far. > if you have any question, please let me know :)
I have replied with comments for your change 2523. But since then I see you've uploaded 2 more changes - but looks like those are the same patches. Please delete the ones that are not needed anymore. > > BTW, when I use "git push review", the git say I don't have change-id. > I finally copy the change-id show in error message. > Is that a proper way to do so? > if not, did I lost any steps to get change-id? Paul has already replied to this. Or see "Patch Guidelines" in the Openocd Developer's guild. David ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ----------------------------------------------------------------------------------- ------------------------------------------------------------------------------ Dive into the World of Parallel Programming. The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ OpenOCD-devel mailing list OpenOCD-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openocd-devel