Paul, you were very fast reviewing Patch Set 5. Faster than Jenkins ;-) But... Before you put CR -2, the change 2282 had +2, was ready to merge. Now the change is waiting in CR +1, waiting for what? I just added documentation as you asked, I hope I don't need to ask my former reviewers to re-review.
Tom On 3.2.2015 12:18, Paul Fertser (Code Review) wrote: > Paul Fertser has posted comments on this change. > > Change subject: psoc4: support for Cypress PSoC 41xx/42xx family > ...................................................................... > > > Patch Set 4: Code-Review-2 > > Hey Tomas, > > Sorry for the slow review. > > The patch looks fine to me but unfortunately missing documentation. Could you > please add the description of the flash driver and its two custom commands to > openocd.texi and mention it in README? Or would you prefer me doing it and > pushing an updated version? I'm putting -2 for now but I promise to remove it > promptly. > > BTW, have you tested this driver with JLink or FTDI? I wonder if it depends > on proper SWD WAIT handling or not. > ------------------------------------------------------------------------------ Dive into the World of Parallel Programming. The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ OpenOCD-devel mailing list OpenOCD-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openocd-devel
