This is an automated email from Gerrit.

Girts Folkmanis ([email protected]) just uploaded a new patch set to Gerrit, 
which you can find at http://openocd.zylin.com/4042

-- gerrit

commit a3db8c9cb805b6ca85db5fdd8f9516a68d5f9e50
Author: Girts Folkmanis <[email protected]>
Date:   Fri Mar 3 09:49:58 2017 -0800

    arm-v7: fix dpm setup
    
    Looks like when some arm64 support was being merged, a comparison
    ended up being inverted. This causes NULL pointer access when
    target attempts to use core cache.
    
    Change-Id: Ic8873ddd13dbdd8100856a71b4717f44cd336e23
    Signed-off-by: Girts Folkmanis <[email protected]>

diff --git a/src/target/arm_dpm.c b/src/target/arm_dpm.c
index f15bff7..3e8180c 100644
--- a/src/target/arm_dpm.c
+++ b/src/target/arm_dpm.c
@@ -973,7 +973,7 @@ int arm_dpm_setup(struct arm_dpm *dpm)
        arm->read_core_reg = arm_dpm_read_core_reg;
        arm->write_core_reg = arm_dpm_write_core_reg;
 
-       if (arm->core_cache != NULL) {
+       if (arm->core_cache == NULL) {
                cache = arm_build_reg_cache(target, arm);
                if (!cache)
                        return ERROR_FAIL;

-- 

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
OpenOCD-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openocd-devel

Reply via email to