[PATCH]: 9cc9819a92 arm_adi_v5: fix scan-build warning [2/3]

[gerrit]

This is an automated email from Gerrit.

"Antonio Borneo <borneo.anto...@gmail.com>" just uploaded a new patch set to 
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/7011

-- gerrit

commit 9cc9819a9252335e1ae6f14b0bc8ffe7f6c296f2
Author: Antonio Borneo <borneo.anto...@gmail.com>
Date:   Wed Jun 1 19:02:54 2022 +0200

    arm_adi_v5: fix scan-build warning [2/3]
    
    Commit d01b3d69ec17 ("arm_adi_v5: separate ROM table parsing from
    command output [3/3]") introduces a new scan-build warning because
    removing one return in case of error causes using uninitialized
    values.
    
    Add back the return on error.
    
    Change-Id: I10ddc548b756d34aaccc0511f091b4caa5ec271a
    Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com>
    Fixes: d01b3d69ec17 ("arm_adi_v5: separate ROM table parsing from command 
output [3/3]")

diff --git a/src/target/arm_adi_v5.c b/src/target/arm_adi_v5.c
index f7b335d95c..0b11e815d5 100644
--- a/src/target/arm_adi_v5.c
+++ b/src/target/arm_adi_v5.c
@@ -1552,8 +1552,10 @@ static int rtp_rom_loop(const struct rtp_ops *ops,
                }
                if (retval == ERROR_OK)
                        retval = dap_run(ap->dap);
-               if (retval != ERROR_OK)
+               if (retval != ERROR_OK) {
                        LOG_DEBUG("Failed read ROM table entry");
+                       return retval;
+               }
 
                if (width == 64) {
                        romentry = (((uint64_t)romentry_high) << 32) | 
romentry_low;

--