[PATCH]: ec2f3e3f34 image: log error when unknown image type is specified

[gerrit]

This is an automated email from Gerrit.

"Marek Vrbka <marek.vr...@codasip.com>" just uploaded a new patch set to 
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/7883

-- gerrit

commit ec2f3e3f347a08f2e6587b5d5dfd2d0b4a5edd61
Author: Marek Vrbka <marek.vr...@codasip.com>
Date:   Tue Sep 5 15:25:50 2023 +0200

    image: log error when unknown image type is specified
    
    This patch adds error reporting when unknown image type is specified.
    Previously, OpenOCD replied with an empty string.
    
    Change-Id: I16220b1f5deb3b966a21731f0adf7911a78e8959
    Signed-off-by: Marek Vrbka <marek.vr...@codasip.com>

diff --git a/src/target/image.c b/src/target/image.c
index f8de7a23e3..d69cd0ae3b 100644
--- a/src/target/image.c
+++ b/src/target/image.c
@@ -91,20 +91,22 @@ static int autodetect_image_type(struct image *image, const 
char *url)
 static int identify_image_type(struct image *image, const char *type_string, 
const char *url)
 {
        if (type_string) {
-               if (!strcmp(type_string, "bin"))
+               if (!strcmp(type_string, "bin")) {
                        image->type = IMAGE_BINARY;
-               else if (!strcmp(type_string, "ihex"))
+               } else if (!strcmp(type_string, "ihex")) {
                        image->type = IMAGE_IHEX;
-               else if (!strcmp(type_string, "elf"))
+               } else if (!strcmp(type_string, "elf")) {
                        image->type = IMAGE_ELF;
-               else if (!strcmp(type_string, "mem"))
+               } else if (!strcmp(type_string, "mem")) {
                        image->type = IMAGE_MEMORY;
-               else if (!strcmp(type_string, "s19"))
+               } else if (!strcmp(type_string, "s19")) {
                        image->type = IMAGE_SRECORD;
-               else if (!strcmp(type_string, "build"))
+               } else if (!strcmp(type_string, "build")) {
                        image->type = IMAGE_BUILDER;
-               else
+               } else {
+                       LOG_ERROR("Unknown image type: %s, use one of: bin, 
ihex, elf, mem, s19, build", type_string);
                        return ERROR_IMAGE_TYPE_UNKNOWN;
+               }
        } else
                return autodetect_image_type(image, url);
 

--