Hi Jan,
Thank you for submitting the patch!
On Sun, May 19, 2024 at 05:32:18PM +0200, Jan Cumps wrote:
> ERROR:SPACING: space required after that ',' (ctx:VxV)
> #23: FILE: src/flash/nor/spi.c:187:
> + FLASH_ID("pu p32q32", 0x03, 0xeb, 0x02, 0xd8, 0xc7, 0x00156085,
> 0x100, 0x10000, 0x4000000),
>
> I used the same formatting rules and spaces a s the other lines in
> that source file:
I'm afraid not exactly, see:
000003f0 2c 20 30 78 31 30 30 30 30 2c c2 a0 30 78 34 30 |, 0x10000,..0x40|
That c2 a0 there...
> This is my first patch attempt. Do I have to change the code?
Yes, please, you need to git commit --amend the patch locally (keep
old Change-Id in the commit message), then check it locally with
included checkpatch and then push to Gerrit again.
HTH
--
Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software!
mailto:[email protected]
