Antonio Borneo:
> On Thu, Jun 20, 2024 at 10:15â¯PM <[email protected]> wrote:
...
> Yes, we switched repo, but I also met this issue after the switch.
> I have run some quick test, and I cannot find any bad impact when adding
> one line in bootstrap
>
> echo "Setting up submodules"
> git submodule init
> + git submodule sync
> git submodule update
>
> Should we add it?
man git-submodule says:
sync [--recursive] [--] [<path>...]
Synchronizes submodules' remote URL configuration setting to the
value specified in .gitmodules. It will only affect those
submodules which already have a URL entry in .git/config (that is
the case when they are initialized or freshly added). This is
useful when submodule URLs change upstream and you need to update
your local repositories accordingly.
and .gitmodules is distributed via git, so it should be safe.
> Karl,
> would you like to propose it as a patch in gerrit?
Yes, it should be safe and it avoids possible confusions in the future.
> We can move the discussion to the gerrit review.
Sorry I cannot since I don't have an openid (nor launchpad).
I already tried to setup some self-hosted one but failed.
Regards,
/Karl Hammar
