Options --help and --version write to stderr instead of stdout

[R. Diez]

Hi all:

I have tried to change in Makefile.am:

AUTOMAKE_OPTIONS = gnu 1.6

to

AUTOMAKE_OPTIONS = gnu 1.6 std-options

That Automake option just verifies that the executable supports options --help 
and --version, which OpenOCD already does.

However, that simple change made "make distcheck" fail. The reason is this code 
in src/helper/options.c:

if (help_flag) {
  LOG_OUTPUT("Open On-Chip Debugger\nLicensed under GNU GPL v2\n");
  LOG_OUTPUT("--help       | -h\tdisplay this help\n");
  ...

Apparently, LOG_OUTPUT writes to stderr, and Automake checks that the output of 
command-line option "--help" goes to stdout and not to stderr:

for opt in --help --version; do \
  if 
"/home/rdiez/rdiez/LocalSoftware/OpenOCD/openocd-dev-distcheck/openocd-0.12.0+dev/_inst/bin/$f"
 $opt >c${pid}_.out \
       2>c${pid}_.err </dev/null \
       && test -n "`cat c${pid}_.out`" \
       && test -z "`cat c${pid}_.err`"; then :; \
  else echo "$f does not support $opt" 1>&2; bad=1; fi; \
done; \

I could submit a patch to change all such calls from LOG_OUTPUT() to printf().

Would that be OK? Or is there a reason why --help should write to stderr?

Regards,
  rdiez