This is an automated email from Gerrit.

"Daniel Goehring <dgoeh...@os.amperecomputing.com>" just uploaded a new patch 
set to Gerrit, which you can find at https://review.openocd.org/c/openocd/+/8870

-- gerrit

commit 5937b35a8a17fbdb9c3dd277a3fae1507a4cc6ed
Author: Daniel Goehring <dgoeh...@os.amperecomputing.com>
Date:   Wed Apr 30 22:38:15 2025 -0400

    target: cget command fix for result output
    
    Function target_configure() when processing a "cget" command needs
    to print the result to the console. Currently the result is only printed
    when an error occurs. To fix this, move the command print statement from
    the error handling section to the common code section.
    
    The code was tested by executing a "$target_name cget -dap" command
    and reviewing the result.
    
    Change-Id: Iff1999de8c8e9a837055ba95714137aa03e68d4b
    Signed-off-by: Daniel Goehring <dgoeh...@os.amperecomputing.com>

diff --git a/src/target/target.c b/src/target/target.c
index 40c8d3ed36..5c6768949f 100644
--- a/src/target/target.c
+++ b/src/target/target.c
@@ -4889,16 +4889,18 @@ static COMMAND_HELPER(target_configure, struct target 
*target, unsigned int inde
                        goi.is_configure = is_configure;
                        int e = (*target->type->target_jim_configure)(target, 
&goi);
                        index = CMD_ARGC - goi.argc;
+
+                       int reslen;
+                       const char *result = 
Jim_GetString(Jim_GetResult(CMD_CTX->interp), &reslen);
+                       if (reslen > 0)
+                               command_print(CMD, "%s", result);
+
                        if (e == JIM_OK) {
                                /* more? */
                                continue;
                        }
                        if (e == JIM_ERR) {
                                /* An error */
-                               int reslen;
-                               const char *result = 
Jim_GetString(Jim_GetResult(CMD_CTX->interp), &reslen);
-                               if (reslen > 0)
-                                       command_print(CMD, "%s", result);
                                return ERROR_FAIL;
                        }
                        /* otherwise we 'continue' below */

-- 

Reply via email to