This is an automated email from Gerrit.

"Tomas Vanek <[email protected]>" just uploaded a new patch set to Gerrit, which 
you can find at https://review.openocd.org/c/openocd/+/9235

-- gerrit

commit b315e36c63b7d6c5c148e3e373d12ae8e1fa6f3f
Author: Tomas Vanek <[email protected]>
Date:   Mon Nov 10 19:30:44 2025 +0100

    target/armv4_5: fix register numbering overlap
    
    Commit b5d2b1224fed ("target/cortex_a: add hypervisor mode")
    added sp_hyp, spsr_hyp registers with gdb_index 51 and 52
    but did not moved FP regs enum base starting from 51.
    
    Move FP registers indices to make room for added registers.
    
    Change-Id: I4338777545918fdf62016e06764308dacea61e98
    Signed-off-by: Tomas Vanek <[email protected]>

diff --git a/src/target/arm.h b/src/target/arm.h
index 79ec99d117..54a25731c2 100644
--- a/src/target/arm.h
+++ b/src/target/arm.h
@@ -108,7 +108,8 @@ enum arm_mode {
 
 /* VFPv3 internal register numbers mapping to d0:31 */
 enum {
-       ARM_VFP_V3_D0 = 51,
+       ARM_VFP_V3_D0 = 53,
+       // numbering should not overlap with e.g. armv4_5.c arm_core_regs 
.gdb_index
        ARM_VFP_V3_D1,
        ARM_VFP_V3_D2,
        ARM_VFP_V3_D3,
diff --git a/src/target/armv4_5.c b/src/target/armv4_5.c
index d1a81614e8..e1a46bad34 100644
--- a/src/target/armv4_5.c
+++ b/src/target/armv4_5.c
@@ -355,6 +355,7 @@ static const struct {
        /* These exist only when the Virtualization Extensions is present */
        [42] = { .name = "sp_hyp", .cookie = 13, .mode = ARM_MODE_HYP, 
.gdb_index = 51, },
        [43] = { .name = "spsr_hyp", .cookie = 16, .mode = ARM_MODE_HYP, 
.gdb_index = 52, },
+       // .gdb_index numbering continues by ARM_VFP_V3_D0
 };
 
 static const struct {

-- 

Reply via email to