This is an automated email from Gerrit. "Antonio Borneo <[email protected]>" just uploaded a new patch set to Gerrit, which you can find at https://review.openocd.org/c/openocd/+/9375
-- gerrit commit acb408dde0f9547a6cdab43bc3feaa28088a2247 Author: Antonio Borneo <[email protected]> Date: Sun Jan 4 17:43:31 2026 +0100 target: openrisc: jsp_server: check for out of memory, fix memory leak During JSP service start, check that memory is properly allocated and if add_service() fails release the allocated memory. Change-Id: I7eb2ea8a10dbeccd27fd39485080552c5d0736d3 Signed-off-by: Antonio Borneo <[email protected]> diff --git a/src/target/openrisc/jsp_server.c b/src/target/openrisc/jsp_server.c index 99abcde110..60cbb49834 100644 --- a/src/target/openrisc/jsp_server.c +++ b/src/target/openrisc/jsp_server.c @@ -195,10 +195,19 @@ static const struct service_driver jsp_service_driver = { int jsp_init(struct or1k_jtag *jtag_info, char *banner) { struct jsp_service *jsp_service = malloc(sizeof(struct jsp_service)); + if (!jsp_service) { + LOG_ERROR("Out of memory"); + return ERROR_FAIL; + } + jsp_service->banner = banner; jsp_service->jtag_info = jtag_info; - return add_service(&jsp_service_driver, jsp_port, 1, jsp_service); + int retval = add_service(&jsp_service_driver, jsp_port, 1, jsp_service); + if (retval != ERROR_OK) + free(jsp_service); + + return retval; } COMMAND_HANDLER(handle_jsp_port_command) --
