On May 17, 2009, at 2:17 PM, Michael Bruck wrote:
_______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-developmentRather than combine them, I'd like to see jtag_queue_command() enforce validation of the command to be enqueued. Then the patterns would be:cmd = cmd_queue_alloc(); cmd->type = JTAG_SCAN; .... jtag_queue_command(cmd);Otherwise, you place a command in the queue before it is filled out. This works fine today where the JTAG queue is manually flushed, but if we ever went to a opportunistic queue draining scheme (device driver pulls next itemoff queue automatically when a command finishes), you could get bogus commands being executed.While I agree in principle I would like to get this patch through first and discuss this suggestion later. My patches are purely code restructuring that should *not* change the algorithms at all. Michael
I agree. I'll get to reviewing the patches in depth tonight and hopefully get them committed.
-- Rick Altherr kc8...@kc8apf.net"He said he hadn't had a byte in three days. I had a short, so I split it with him."
-- Unsigned
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development