On Tue, 2009-06-30 at 21:20 -0400, Duane Ellis wrote: > > However, I would rather see you move some of the things in the C file > > into the H file (all of the #defines and struct declarations, to start). > > Basically, use it as the driver's private header file. > > > > None of those defines are *PUBLIC*. > None of those structures are *PUBLIC*. > > The public interface to that file is exactly the structure with method > pointers, nothing else. > > By putting these things a header file, we effectively are creating a > contract that these things will continue to be available to other users. > > Please explain why *private* things to an implementation should be made > public.
Read what I said again: "private header file". Just because something is in a header file does not mean it is a public contract. However, putting this into your terms: moving those definitions to H file helps define the "contract" for the C file. Cheers, Zach _______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
