- I would leave the check for HALTED at the target level because in
principle it depends on the capabilities of the debug interface if
this check is necessary.

- In target.c

if (CRm>7)

should be

if (CRm > 15)


Michael

On Mon, Oct 26, 2009 at 20:04, Øyvind Harboe <oyvind.har...@zylin.com> wrote:
> On Mon, Oct 26, 2009 at 5:27 PM, Michael Bruck <mbr...@digenius.de> wrote:
>> I haven't tested the patch, but the "retire" part forgets to eliminate
>> arm11_coproc_instruction_limits[].
>>
>> The new code should also check for:
>>
>>  if (arm11->target->state != TARGET_HALTED)
>>  {
>>     LOG_WARNING("target was not halted");
>>     return ERROR_TARGET_NOT_HALTED;
>> }
>
> This is fixed in the mrcmcr branch at:
>
> http://repo.or.cz/w/openocd/oharboe.git
>
>
> --
> Øyvind Harboe
> http://www.zylin.com/zy1000.html
> ARM7 ARM9 ARM11 XScale Cortex
> JTAG debugger and flash programmer
>
_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to