I didn't do anything clever here.

Reading the cortex_a9/a8.c logs it looked like Cortex A8 had simply
been abandoned, so I copied cortex_a9.c onto cortex_a8.c, did a quick
search and replace job and deleted cortex_a9.c.

Any objections?

Insights?

Does this look OK?

Are all the changes that went into cortex_a9.c appropriate for cortex_a8?

git log -- src/target/cortex_a9.c >ll.txt


-- 
Øyvind Harboe

Can Zylin Consulting help on your project?

US toll free 1-866-980-3434 / International +47 51 87 40 27

http://www.zylin.com/zy1000.html
ARM7 ARM9 ARM11 XScale Cortex
JTAG debugger and flash programmer
commit bd115084c2813d1a5e511c9e4b468c8dce783fee
Author: Øyvind Harboe <oyvind.har...@zylin.com>
Date:   Mon Mar 21 14:10:57 2011 +0100

    cortex a9: merge cortex a9 and a8 code
    
    better to keep this in a single file.
    
    Signed-off-by: Øyvind Harboe <oyvind.har...@zylin.com>

commit fa93174a56c0aca1201bebf88795d6fe31c18aa1
Author: Luca Ellero <lro...@gmail.com>
Date:   Mon Feb 14 21:46:53 2011 +0000

    arm_adi_v5: add/move apsel member in struct adiv5_dap
    
    This patch tries to make some order in "apsel" mess.
    "dap apsel" command was quite useless (and broken) by itself.
    With this patch we can use it to select between AHB or APB memory access
    (previous patch 05ab8bdb813acdcd74afa71d6656c2df816cb230 was somehow 
broken).
    
    - moves member apsel (in struct adiv5_dap) to ap_current
    - adds apsel member
    
    this strange choice is made trying to keep coherence in "dap apsel" command
     and to keep compatibility with other code (for example cortex_a8).
    
    Signed-off-by: Luca Ellero <lro...@gmail.com>

commit 779005f43dc372de937dfd4b445f31d882b98eca
Author: Luca Ellero <lro...@gmail.com>
Date:   Sat Feb 12 11:54:42 2011 +0000

    cortex_a9: move dap_ap_select to arm_avi_v5
    
    dap_ap_select was used in the code at various points, but that can lead to
    confusion, without any knowledge of what AP is really selected at some
    points.
    Some bugs derive from this (for example md/mw doesn't work well after
    issueing "dap apsel" command).
    Moving it to arm_adi_v5.c (using  mem_ap_sel* functions instead of mem_ap_*)
    make the code more clear and more easier to maintain.
    In the future it should be made "static" to avoid its use outside arm_adi_v5
    
    One further benefit is the various goto has been removed as well
    
    Signed-off-by: Luca Ellero <lro...@gmail.com>

commit aaa52e16ce9b6d43d2fa578361a582ccd9e6c85d
Author: Luca Ellero <lro...@gmail.com>
Date:   Sat Feb 12 11:54:39 2011 +0000

    cortex_a9: check if MMU is enabled on APB read/write memory
    
    Signed-off-by: Luca Ellero <lro...@gmail.com>

commit f609d03f1fc0b722584f624fe25b04efd362ef00
Author: Luca Ellero <lro...@gmail.com>
Date:   Sat Feb 12 11:54:38 2011 +0000

    cortex_a9: check target halted on APB read/write memory
    
    Signed-off-by: Luca Ellero <lro...@gmail.com>

commit 28b953d0bd615ec6ec41a89546a757e73f9b0bdf
Author: Luca Ellero <lro...@gmail.com>
Date:   Sat Feb 12 11:54:37 2011 +0000

    cortex_a9: trivial fixes
    
    Signed-off-by: Luca Ellero <lro...@gmail.com>

commit 05ab8bdb813acdcd74afa71d6656c2df816cb230
Author: Luca Ellero <lro...@gmail.com>
Date:   Wed Feb 9 20:36:14 2011 +0000

    cortex_a9: implement read/write memory through APB-AP
    
    This patch adds read/write capability to memory addresses not
    accessible through AHB-AP (for example "boot ROM code").
    
    To select AHB or APB, a "dap apsel" command must be issued:
    dap apsel 0 -> following memory accesses are through AHB
    dap apsel 1 -> following memory accesses are through APB
    
    NOTE: at the moment APB memory accesses are very slow, compared
          to AHB accesses. Work has to be done to get it faster (for
          example LDR/STR instead od LDRB/STRB)
    
    Signed-off-by: Luca Ellero <lro...@gmail.com>

commit 94e90cbf16cb14c997e68b780b1c4397f2cc2257
Author: Aaron Carroll <aar...@cse.unsw.edu.au>
Date:   Thu Feb 3 12:06:14 2011 +1100

    cortex_a9: fix dap_ap_select() usage
    
    Save, select and restore AP in cortex_a9_step and 
cortex_a9_init_debug_access.
    Fixes a bug where the wrong AP is selected after a reset.
    
    Signed-off-by: Aaron Carroll <aar...@cse.unsw.edu.au>

commit d51b561b10bc516bf76ced479b73ae1c7b170cf7
Author: Luca Ellero <lro...@gmail.com>
Date:   Tue Feb 8 05:16:54 2011 +0000

    cortex_a8/a9: fix some comments
    
    Signed-off-by: Luca Ellero <lro...@gmail.com>

commit c34e69cb10bb9c7502732d2bb0bc92fa73235aec
Author: Aaron Carroll <aar...@cse.unsw.edu.au>
Date:   Mon Jan 24 18:06:46 2011 +1100

    cortex_a9: add source files for Cortex A9 support.
    
    add target and build support for A9
    
    Signed-off-by: Aaron Carroll <aar...@cse.unsw.edu.au>
_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to