Andreas Fritiofson wrote: > I'm not very fond of the "infinite-loop-that's-not-actually-a-loop-at-all" > along with the extra indentation.
+1 > This patch doesn't use gotos either but another (perhaps even more) > neglected construct, like it or not. :) Hah. I wouldn't have done it this way, but it's your patch. > From c934a6c697c90fd5b5211f744e6607ae9cb7b848 Mon Sep 17 00:00:00 2001 > From: Andreas Fritiofson <andreas.fritiof...@gmail.com> > Date: Wed, 8 Jun 2011 23:58:51 +0200 > Subject: [PATCH] ft2232: clean up on error in ft2232_init() > > Check malloc return value. > Close handle and free buffer if init fails late. Reuse ft2232_quit() for > this so move it up to avoid a forward declaration. > Don't set retval if it's not used. > > Signed-off-by: Andreas Fritiofson <andreas.fritiof...@gmail.com> I'm inclined to say Acked-by: Peter Stuge <pe...@stuge.se> But I'd like a separate commit for either moving _quit() or simply adding a prototype and leaving it in place. //Peter _______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
