On Tue, Jun 28, 2005, Bill Campbell wrote:
> [...]
> --- rc.spamassassin.orig Tue Jun 28 09:29:44 2005
> +++ rc.spamassassin Tue Jun 28 10:23:01 2005
> @@ -12,6 +12,12 @@
> spamassassin_log_numfiles="10"
> spamassassin_log_minsize="1M"
> spamassassin_log_complevel="9"
> + # These options control various startup options, and are
> + # included here to allow changes in the @l_prefix@/etc/rc.conf file.
> + # Allow local private networks and local host to connect
> + spamassassin_allowed_ips='-A 192.168. -A 127.'
> + # Use only local tests
> + spamassassin_local_only='--local'
>
> %common
> spamassassin_pidfile="@l_prefix@/var/spamassassin/spamassassin.pid"
> @@ -36,7 +42,8 @@
> --pidfile="${spamassassin_pidfile}" \
> --listen-ip="${spamassassin_iface}" \
> --port="${spamassassin_port}" \
> - --local
> + $spamassassin_allowed_ips \
> + $spamassassin_local_only
>
> %stop -p 400 -u @l_susr@
> rcService spamassassin enable yes || exit 0
Ok, good idea. Just two suggestions:
First I personally would not add those comments to the %config section
(because we never have comments in any %config section and if we comment
two variables we actually have to comment the others, too).
Second, for more flexibility and to align with other packages, would it
make sense to use just a single 'spamassassin_flags="-A 127. --local"'
variable? Because I always tend to the following: either a variable
named "spamassassin_allowed_ips" is really just a list of IPs (as its
name indicates) or if it is really a list of command line flags its
better to merge this with a more generic and reusable variable like
"spamassassin_flags".
So, I personally would adjust this patch slightly to read just:
Index: rc.spamassassin
--- rc.spamassassin 7 Dec 2004 19:57:40 -0000 1.13
+++ rc.spamassassin 28 Jun 2005 20:00:31 -0000
@@ -7,6 +7,7 @@
spamassassin_enable="$openpkg_rc_def"
spamassassin_iface="127.0.0.1"
spamassassin_port="783"
+ spamassassin_flags="-A 127. --local"
spamassassin_log_prolog="true"
spamassassin_log_epilog="true"
spamassassin_log_numfiles="10"
@@ -36,7 +37,7 @@
--pidfile="${spamassassin_pidfile}" \
--listen-ip="${spamassassin_iface}" \
--port="${spamassassin_port}" \
- --local
+ ${spamassassin_flags}
%stop -p 400 -u @l_susr@
rcService spamassassin enable yes || exit 0
Are you still happy with this, Bill?
Ralf S. Engelschall
[EMAIL PROTECTED]
www.engelschall.com
______________________________________________________________________
The OpenPKG Project www.openpkg.org
Developer Communication List openpkg-dev@openpkg.org
