On Tue, Jun 28, 2005, Ralf S. Engelschall wrote: >On Tue, Jun 28, 2005, Bill Campbell wrote: > ... >Ok, good idea. Just two suggestions: > >First I personally would not add those comments to the %config section >(because we never have comments in any %config section and if we comment >two variables we actually have to comment the others, too).
Personally I would like to see more comments in the run control files. Generally I think it would be a Good Idea(tm) to let others know the logic behind some of the variables. As an example, the behaviour of the 127.0.0.1 listening options varies from package to package (e.g. in rsync, setting it to "" causes the daemon to listen on all interfaces, while many others require that one set it to "0.0.0.0" I really liked it when many things were standardized in the rc files about Release 2.0 or so, and I would like to see some additional standardization, where possible, in things like this. >Second, for more flexibility and to align with other packages, would it >make sense to use just a single 'spamassassin_flags="-A 127. --local"' >variable? Because I always tend to the following: either a variable >named "spamassassin_allowed_ips" is really just a list of IPs (as its >name indicates) or if it is really a list of command line flags its >better to merge this with a more generic and reusable variable like >"spamassassin_flags". Again, this is a matter of style. I prefer to keep things simple, with one function per variable, preferably with descriptive names, rather than lump them all together. Descriptive variable names and comments make it easier for someone unfamiliar with an rc file to figure out what's going on without having to understand shell scripting. ... >Are you still happy with this, Bill? Generally yes :-). It takes care of the major problem. Bill -- INTERNET: [EMAIL PROTECTED] Bill Campbell; Celestial Software LLC UUCP: camco!bill PO Box 820; 6641 E. Mercer Way FAX: (206) 232-9186 Mercer Island, WA 98040-0820; (206) 236-1676 URL: http://www.celestial.com/ Imagine if every Thursday your shoes exploded if you tied them the usual way. This happens to us all the time with computers, and nobody thinks of complaining. -- Jef Raskin http://jefraskin.com/ ______________________________________________________________________ The OpenPKG Project www.openpkg.org Developer Communication List openpkg-dev@openpkg.org
