I checked the NDs. I think we should remove these sleeps(legacy). Also, the exits should be styled like the daemon_exit()s.
We also need to test such ‘exit’s from the terminatecallback for directors as well and consider special classes like NTF where we ought to call the likes of stop_ntfimcn(). Will get back on this. Thanks, Mathi. From: Praveen [mailto:[email protected]] Sent: Monday, July 15, 2013 9:35 AM To: [opensaf:tickets] Subject: [opensaf:tickets] Re: #501 amf: No node directors register to AMF within time after "#7 cleanup instead of terminate used at component restart" Can sleep(1) be added before giving response to AMF? Thanks Praveen On 15-Jul-13 8:10 AM, Nagendra Kumar wrote: There is no problem with AMF as amf is running instantiate script for all the services(cpnd, glnd, mqnd, smfnd). The problem resides in these services, because it is sleeping for 1 seconds after giving amf response in the terminate callback. Ex: cpnd_amf_comp_terminate_callback saAmfResponse(cb->amf_hdl, invocation, saErr); ncshm_give_hdl(gl_cpnd_cb_hdl); sleep(1); LOG_NO("Received AMF component terminate callback, exiting"); exit(0); When instantiate script is executed by amf, since the process is still up and running(because of sleep of 1 second), 'start_daemon -p $pidfile $binary $args' becomes ineffective and the processes(e.g. cpnd) doesn't start. I tested by removing sleep and all worked as expected. So, it is advised in other services to find out why sleep of 1 was introduced and how we can get rid of sleep. _____ HYPERLINK "http://sourceforge.net/p/opensaf/tickets/501/"[tickets:#501] http://sourceforge.net/p/opensaf/tickets/501/ amf: No node directors register to AMF within time after "#7 cleanup instead of terminate used at component restart" Status: unassigned Created: Thu Jul 11, 2013 07:47 AM UTC by Ingvar Bergström Last Updated: Thu Jul 11, 2013 07:47 AM UTC Owner: nobody After introduction of patches solving "#7 cleanup instead of terminate used at component restart", no node directors registers to AMF within time according to messages log. I have tried SMFND, CPND, GLND and MQND. It seems however that the main routines of the node director daemons are not started until 10 seconds after the terminate callback (after the registration timeout). It is very easy to see the fault by entering command "amf-adm restart safComp=xxxND,safSu=SC-1,safSg=NoRed,safApp=OpenSAF" _____ Sent from sourceforge.net because HYPERLINK "mailto:[email protected]"[email protected] is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list. _____ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk _____ Opensaf-tickets mailing list HYPERLINK "mailto:[email protected]"[email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-tickets _____ HYPERLINK "http://sourceforge.net/p/opensaf/tickets/501/"[tickets:#501] amf: No node directors register to AMF within time after "#7 cleanup instead of terminate used at component restart" Status: unassigned Created: Thu Jul 11, 2013 07:47 AM UTC by Ingvar Bergström Last Updated: Mon Jul 15, 2013 02:42 AM UTC Owner: nobody After introduction of patches solving "#7 cleanup instead of terminate used at component restart”, no node directors registers to AMF within time according to messages log. I have tried SMFND, CPND, GLND and MQND. It seems however that the main routines of the node director daemons are not started until 10 seconds after the terminate callback (after the registration timeout). It is very easy to see the fault by entering command "amf-adm restart safComp=xxxND,safSu=SC-1,safSg=NoRed,safApp=OpenSAF" _____ Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/opensaf/tickets/501/ To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/ ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
