Summary: set rda role when failover is trigerred in the middle of switchover [#438] Review request for Trac Ticket(s): #438 Peer Reviewer(s): Hans or Ramesh or Anders or Nagendra Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): 4.3.x, default Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services y Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- The problem: ============ A switchover of controller nodes is defined as 'complete' when AMF sets the RDA role of the controllers. During a switchover, AMF first swaps the role of the 2N components of the middleware 2N SU and subsequently sets the rda role. A situation when swithchover is in progress and the old ACTIVE dies must be treated/escalated as a failover, but currenlty FM is not acting upon the node down indiciation of the old ACTIVE controller because FM is assuming that this node is already ACTIVE and so does not takes actions related to failover. The reason for is that FM is storing rda role and AMF state in the same variable. Now, due to this(same varible) when switchover is in progress, AMF would have asked FM to go active via the csisetcallback, but when AMF has not yet changed the RDA role, FM fails to act on a NODE down indication of old ACTIVE because FM is assuming that this node is already fully active, but in reality this node is not ACTIVE completely. In reality this is a situation where the old active has died, and this controller has not fully transitioned to new ACTIVE. The solution: ============= The patch makes FM to subscribe for RDA callback and stores rda and FM role in different variables. So, in the above mentioned situation, FM will rely on the RDA role to determine whether it is a fully functional ACTIVE or not and will thus be able to perform FAILOVER actions upon receiving the node down indication of the peer controller. changeset 62bc0fd2f4c9a6ea5adcdae07f9cec1d6f6f9844 Author: [email protected] Date: Tue, 16 Jul 2013 13:11:00 +0530 fm: set rda role when failover is trigerred in the middle of switchover [438] Complete diffstat: ------------------ osaf/services/infrastructure/fm/fms/fm_amf.c | 2 +- osaf/services/infrastructure/fm/fms/fm_cb.h | 3 +++ osaf/services/infrastructure/fm/fms/fm_evt.h | 6 ++++++ osaf/services/infrastructure/fm/fms/fm_main.c | 87 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------- 4 files changed, 77 insertions(+), 21 deletions(-) Testing Commands: ----------------- 1) Trigger switchover 2) Induce a fault in the old active node such that the old active goes for a reboot 3) Without this patch, the standby does nothing and the cluster is unstable. With this patch, The STANDby controller should become active successfully. Testing, Expected Results: -------------------------- Same as above. However, the following additional tests also should be performed. 1) Normalfailover 2) Switchover 3) Reboot of Standby 4) Reboot of active when standby initiailization is not yet complete. Conditions of Submission: ------------------------- Ack from Nagendra or Ramesh or Hans or Anders Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
