Summary: dtm: Don't use NULL pointers or uninitialized data in error paths
[#526]
Review request for Trac Ticket(s): 526
Peer Reviewer(s): Mahesh
Pull request to:
Affected branch(es): opensaf-4.2.x, opensaf-4.3.x, default(4.4)
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services y
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset 3c457ee245d95fbb2a0fa1d01658a4f923f5abdc
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Wed, 31 Jul 2013 10:51:58 +0200
dtm: Don't use NULL pointers or uninitialized data in error paths [#526]
Fixed two bugs where LOG_ER() was called with illegal parameters in
error
paths:
* The error path taken when inet_ntop() fails was using the string in
the
uninitialized result buffer.
* The error path taken when dtm_node_new() returns NULL was
dereferencing
the returned NULL pointer.
Complete diffstat:
------------------
osaf/services/infrastructure/dtms/dtm/dtm_node_sockets.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
Testing Commands:
-----------------
Compile and start OpenSAF with TCP transport.
Testing, Expected Results:
--------------------------
OpenSAF should compile and start successfully.
Conditions of Submission:
-------------------------
Ack from Mahesh
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Get your SQL database under version control now!
Version control is standard for application code, but databases havent
caught up. So what steps can you take to put your SQL databases under
version control? Why should you start doing it? Read more to find out.
http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
