Anders Widell,
ACK from me and thanks for the patch .
-AVM
On 7/31/2013 3:57 PM, Anders Widell wrote:
> osaf/services/infrastructure/dtms/dtm/dtm_node_sockets.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>
> Fixed two bugs where LOG_ER() was called with illegal parameters in error
> paths:
>
> * The error path taken when inet_ntop() fails was using the string in the
> uninitialized result buffer.
>
> * The error path taken when dtm_node_new() returns NULL was dereferencing
> the returned NULL pointer.
>
> diff --git a/osaf/services/infrastructure/dtms/dtm/dtm_node_sockets.c
> b/osaf/services/infrastructure/dtms/dtm/dtm_node_sockets.c
> --- a/osaf/services/infrastructure/dtms/dtm/dtm_node_sockets.c
> +++ b/osaf/services/infrastructure/dtms/dtm/dtm_node_sockets.c
> @@ -1320,7 +1320,7 @@ int dtm_process_accept(DTM_INTERNODE_CB
>
> /* Convert binary to printable address */
> if (inet_ntop(clnt_addr1->sa_family, numericAddress, addrBuffer,
> sizeof(addrBuffer)) == NULL) {
> - LOG_ER("DTM:[invalid address] %s ", addrBuffer);
> + LOG_ER("DTM: [invalid address]");
> dtm_comm_socket_close(&new_conn_sd);
> goto done;
> } else {
> @@ -1335,7 +1335,7 @@ int dtm_process_accept(DTM_INTERNODE_CB
> new_node = dtm_node_new(&node);
>
> if (new_node == NULL) {
> - LOG_ER("DTM: dtm_node_add failed .node_ip: %s, node_id:
> %u", new_node->node_ip, new_node->node_id);
> + LOG_ER("DTM: dtm_node_new failed. node_ip: %s, node_id:
> %u", node.node_ip, node.node_id);
> dtm_comm_socket_close(&new_conn_sd);
> goto node_fail;
> }
------------------------------------------------------------------------------
Get your SQL database under version control now!
Version control is standard for application code, but databases havent
caught up. So what steps can you take to put your SQL databases under
version control? Why should you start doing it? Read more to find out.
http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
