Summary: IMMTEST: Cleanup the code and fix memory problem [#552] Review request for Trac Ticket(s): 552 Peer Reviewer(s): Neel Pull request to: Zoran Affected branch(es): opensaf-4.3.x Development branch: opensaf-4.3.x
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries n Samples n Tests y Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 6e718b7dfad5d813286331a7498cdc3351591288 Author: Zoran Milinkovic <zoran.milinko...@ericsson.com> Date: Thu, 12 Sep 2013 04:40:23 -0400 IMMTEST: Cleanup the code and fix memory problem [#552] Complete diffstat: ------------------ tests/immsv/common/immtest.c | 4 ++++ tests/immsv/implementer/test_SaImmOiRtAttrUpdateCallbackT.c | 2 +- tests/immsv/implementer/test_cleanup.c | 2 +- tests/immsv/management/test_cleanup.c | 2 +- tests/immsv/management/test_saImmOmAdminOwnerFinalize.c | 1 + tests/immsv/management/test_saImmOmInitialize.c | 1 + tests/immsv/management/test_saImmOmSearchInitialize_2.c | 2 +- tests/immsv/management/test_saImmOmThreadInterference.c | 10 +++++++--- 8 files changed, 17 insertions(+), 7 deletions(-) Testing Commands: ----------------- valgrind --leak-check=full --show-reachable=yes --track-origins=yes immomtest valgrind --leak-check=full --show-reachable=yes --track-origins=yes immoitest Testing, Expected Results: -------------------------- Valgrind should not report any memory leak. Conditions of Submission: ------------------------- Ack from Neel. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ How ServiceNow helps IT people transform IT departments: 1. Consolidate legacy IT systems to a single system of record for IT 2. Standardize and globalize service processes across IT 3. Implement zero-touch automation to replace manual, redundant tasks http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel