Would be nice if a text file with commands could contain comments like: # add the objects... immcfg ...
Thanks, Hans On 09/09/2013 10:44 AM, Zoran Milinkovic wrote: > I will add the description and examples with the next patch. > > Will be added to DESCRIPTION: > Running immcfg without arguments, immcfg starts in explicit commit mode where > is possible to perform more IMM operations within one CCB. In explicit commit > mode, immcfg accepts immcfg commands from stdin, pipe or a file. > > Will be added to EXAMPLE: > cat test.cfg | immcfg > Running immcfg in explicit commit mode where immfg accepts immcfg > commands from a pipe > immcfg < test.cfg > Running immcfg in explicit commit mode where immcfg accepts immcfg > commands from test.cfg file > immcfg > Running immcfg in explicit commit mode where immcfg accepts immcfg > commands from command line > > BR, > Zoran > > -----Original Message----- > From: Hans Feldt > Sent: den 9 september 2013 09:01 > To: Zoran Milinkovic > Cc: reddy.neelaka...@oracle.com; opensaf-devel@lists.sourceforge.net > Subject: Re: [devel] [PATCH 0 of 1] Review Request for IMMTOOLS: add > transactions to immcfg [#20] > > Hi, > > I think some help text is missing (even better a man page but that is for > later). > > I don't understand how to use this feature. > > Could you explain here first and add into the help text of immcfg? > > Thanks, > Hans > > On 07/18/2013 03:27 PM, Zoran Milinkovic wrote: >> Summary: IMMTOOLS: add transactions to immcfg [#20] Review request for >> Trac Ticket(s): 20 Peer Reviewer(s): Neel, Anders Pull request to: >> Zoran Affected branch(es): default(4.4) Development branch: >> >> -------------------------------- >> Impacted area Impact y/n >> -------------------------------- >> Docs n >> Build system n >> RPM/packaging n >> Configuration files n >> Startup scripts n >> SAF services y >> OpenSAF services n >> Core libraries n >> Samples n >> Tests n >> Other n >> >> >> Comments (indicate scope for each "y" above): >> --------------------------------------------- >> >> changeset 0ed7f10cc24733dde0f99720aacec7e9ff6b4bdd >> Author: Zoran Milinkovic <zoran.milinko...@ericsson.com> >> Date: Thu, 18 Jul 2013 15:13:34 +0200 >> >> IMMTOOLS: add transactions to immcfg [#20] >> >> immcfg without parameters runs in transaction mode. immcfg operations in >> transaction mode can be accepted from a pipe, a file or stdin (command >> line). Ctrl+D commit a transaction and exit. Ctrl+C abort a transaction >> and >> exit. >> >> >> Complete diffstat: >> ------------------ >> osaf/tools/safimm/immcfg/imm_cfg.c | 794 >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------------- >> osaf/tools/safimm/immcfg/imm_import.cc | 908 >> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------- >> 2 files changed, 1238 insertions(+), 464 deletions(-) >> >> >> Testing Commands: >> ----------------- >> immcfg >> cat testfile.cfg | immcfg >> immcfg < testfile.cfg >> >> >> Testing, Expected Results: >> -------------------------- >> Run immcfg in a command line mode, ex: "immcfg" >> Use a pipe as the input, ex: "cat testfile.cfg | immcfg" >> Use a file as the input, ex: "immcfg < testfile.cfg" >> >> >> Conditions of Submission: >> ------------------------- >> Ack from Neel and Anders >> >> >> Arch Built Started Linux distro >> ------------------------------------------- >> mips n n >> mips64 n n >> x86 n n >> x86_64 n n >> powerpc n n >> powerpc64 n n >> >> >> Reviewer Checklist: >> ------------------- >> [Submitters: make sure that your review doesn't trigger any >> checkmarks!] >> >> >> Your checkin has not passed review because (see checked entries): >> >> ___ Your RR template is generally incomplete; it has too many blank entries >> that need proper data filled in. >> >> ___ You have failed to nominate the proper persons for review and push. >> >> ___ Your patches do not have proper short+long header >> >> ___ You have grammar/spelling in your header that is unacceptable. >> >> ___ You have exceeded a sensible line length in your headers/comments/text. >> >> ___ You have failed to put in a proper Trac Ticket # into your commits. >> >> ___ You have incorrectly put/left internal data in your comments/files >> (i.e. internal bug tracking tool IDs, product names etc) >> >> ___ You have not given any evidence of testing beyond basic build tests. >> Demonstrate some level of runtime or other sanity testing. >> >> ___ You have ^M present in some of your files. These have to be removed. >> >> ___ You have needlessly changed whitespace or added whitespace crimes >> like trailing spaces, or spaces before tabs. >> >> ___ You have mixed real technical changes with whitespace and other >> cosmetic code cleanup changes. These have to be separate commits. >> >> ___ You need to refactor your submission into logical chunks; there is >> too much content into a single commit. >> >> ___ You have extraneous garbage in your review (merge commits etc) >> >> ___ You have giant attachments which should never have been sent; >> Instead you should place your content in a public tree to be pulled. >> >> ___ You have too many commits attached to an e-mail; resend as threaded >> commits, or place in a public tree for a pull. >> >> ___ You have resent this content multiple times without a clear indication >> of what has changed between each re-send. >> >> ___ You have failed to adequately and individually address all of the >> comments and change requests that were proposed in the initial review. >> >> ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) >> >> ___ Your computer have a badly configured date and time; confusing the >> the threaded patch review. >> >> ___ Your changes affect IPC mechanism, and you don't present any results >> for in-service upgradability test. >> >> ___ Your changes affect user manual and documentation, your patch series >> do not contain the patch that updates the Doxygen manual. >> >> >> ---------------------------------------------------------------------- >> -------- See everything from the browser to the database with >> AppDynamics Get end-to-end visibility with application monitoring from >> AppDynamics Isolate bottlenecks and diagnose root cause in seconds. >> Start your free trial of AppDynamics Pro today! >> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.c >> lktrk _______________________________________________ >> Opensaf-devel mailing list >> Opensaf-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/opensaf-devel >> >> > > ------------------------------------------------------------------------------ How ServiceNow helps IT people transform IT departments: 1. Consolidate legacy IT systems to a single system of record for IT 2. Standardize and globalize service processes across IT 3. Implement zero-touch automation to replace manual, redundant tasks http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
