Summary: use common sigterm handler [#512]
Review request for Trac Ticket(s): #512
Peer Reviewer(s): anders.wid...@ericsson.com
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): 4.4.x, default
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
All OpenSAF core services and CPD already install the
common sigterm handler.
This patch series takes a stab at the optional services.
PLM is pending. Will send a separate patch for that.
changeset ad694a098f13a829e051a196194b0da1bbac261d
Author: Mathivanan N.P.<mathi.naic...@oracle.com>
Date: Tue, 18 Feb 2014 20:28:26 -0500
evt: use daemon_sigterm_install [#512] All core services and cpsv now
register for a common sigterm handler. This patch series takes a stab
at the
optional services
changeset 5d1b126dbf643b5c890d669a89069f296ea10046
Author: Mathivanan N.P.<mathi.naic...@oracle.com>
Date: Tue, 18 Feb 2014 20:30:16 -0500
lck: gld to use daemon_sigterm_install [#512] All core services and
cpsv now
register for a common sigterm handler. This patch series takes a stab
at the
optional services
changeset 9ff8677841414b28134e54be71f2bd795aeacf7a
Author: Mathivanan N.P.<mathi.naic...@oracle.com>
Date: Tue, 18 Feb 2014 20:31:03 -0500
lck: glnd to use daemon_sigterm_install [#512] All core services and
cpsv
now register for a common sigterm handler. This patch series takes a
stab at
the optional services
changeset f3715344e800a6449fddc22426284542dad87ccc
Author: Mathivanan N.P.<mathi.naic...@oracle.com>
Date: Tue, 18 Feb 2014 20:31:26 -0500
msg: mqd to use daemon_sigterm_install [#512] All core services and
cpsv now
register for a common sigterm handler. This patch series takes a stab
at the
optional services
changeset 7d94fd93c2c201fd5a10379af1d8fdefe28a0d8a
Author: Mathivanan N.P.<mathi.naic...@oracle.com>
Date: Tue, 18 Feb 2014 20:32:10 -0500
msg: mqnd to use daemon_sigterm_install [#512] All core services and
cpsv
now register for a common sigterm handler. This patch series takes a
stab at
the optional services
Complete diffstat:
------------------
osaf/libs/common/edsv/include/eds.h | 2 ++
osaf/libs/common/glsv/include/gld.h | 2 ++
osaf/libs/common/glsv/include/glnd.h | 2 ++
osaf/libs/common/mqsv/include/mqd.h | 2 ++
osaf/libs/common/mqsv/include/mqnd.h | 2 ++
osaf/services/saf/edsv/eds/eds_cb.c | 33 ++++++++++++++++++++++++---------
osaf/services/saf/edsv/eds/eds_main.c | 1 -
osaf/services/saf/glsv/gld/gld_api.c | 30 ++++++++++++++++++++++--------
osaf/services/saf/glsv/gld/gld_main.c | 1 -
osaf/services/saf/glsv/glnd/glnd_api.c | 15 +++++++++++++--
osaf/services/saf/mqsv/mqd/mqd_api.c | 26 ++++++++++++++++++++------
osaf/services/saf/mqsv/mqd/mqd_main.c | 1 -
osaf/services/saf/mqsv/mqnd/mqnd_init.c | 31 +++++++++++++++++++++++--------
osaf/services/saf/mqsv/mqnd/mqnd_main.c | 1 -
14 files changed, 112 insertions(+), 37 deletions(-)
Testing Commands:
-----------------
Upon /etc/init.d/opensafd stop,
these optional services should print "exiting for shutdown" message
in the syslog and without any core.
performed repeatged swithcover, failover.
Testing, Expected Results:
--------------------------
Upon /etc/init.d/opensafd stop,
these optional services should print "exiting for shutdown" message
in the syslog.
Conditions of Submission:
-------------------------
Ack from Anders.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121054471&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
