Hi zoran, Reviewed the patches for 4.2.x, 4.3.x, 4.4.x(default). Tested with 4.2.x . Ack for all patches.
/Neel. On Friday 21 February 2014 10:07 PM, Zoran Milinkovic wrote: > Summary: IMM: add support for forwards compatibility of attribute flags [#116] > Review request for Trac Ticket(s): 116 > Peer Reviewer(s): Neelakanta > Pull request to: Zoran > Affected branch(es): opensaf-4.2.x > Development branch: opensaf-4.2.x > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services y > OpenSAF services n > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > > changeset 5d03eb30ac8a399dfef00880331ac5673c5842ac > Author: Zoran Milinkovic <zoran.milinko...@ericsson.com> > Date: Fri, 21 Feb 2014 17:18:28 +0100 > > IMM: add support for forwards compatibility of attribute flags [#116] > > changeset fa1c55912ed6115122be1960ad4d31631fe42de3 > Author: Zoran Milinkovic <zoran.milinko...@ericsson.com> > Date: Fri, 21 Feb 2014 17:21:37 +0100 > > IMMTOOLS: add support for forwards compatibility of attribute flags > [#116] > > For forwards compatibility, OpenSAF schema, where unknown attribute > flags > are defined, must be provided to immcfg using -X flag. If immload finds > unknown attribute flag, immload will try to find the attribute flag in > the > schema defined in the top element of the loading IMM XML file. > > > Complete diffstat: > ------------------ > osaf/services/saf/immsv/immnd/ImmModel.cc | 39 > ++++++++++++++++++++++++++++------ > osaf/services/saf/immsv/immnd/ImmSearchOp.cc | 2 +- > osaf/services/saf/immsv/immnd/ImmSearchOp.hh | 4 +- > osaf/tools/safimm/immcfg/imm_cfg.c | 31 > ++++++++++++++++++++++----- > osaf/tools/safimm/immcfg/imm_import.cc | 178 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------- > osaf/tools/safimm/immlist/imm_list.c | 6 ----- > osaf/tools/safimm/immload/imm_loader.cc | 150 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------- > 7 files changed, 368 insertions(+), 42 deletions(-) > > > Testing Commands: > ----------------- > immcfg -X schema_with_unknown_flags.xsd imm.xml > > > Testing, Expected Results: > -------------------------- > When OpenSAF starts without PBE enabled, immload must successfuly load > imm.xml with unknown flags, if unknown flags are defined in a schema of > loading imm.xml file. The schema must be in the same directory as imm.xml. > > > Conditions of Submission: > ------------------------- > Ack from Neelakanta > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 n n > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > ------------------------------------------------------------------------------ Flow-based real-time traffic analytics software. Cisco certified tool. Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer Customize your own dashboards, set traffic alerts and generate reports. Network behavioral analysis & security monitoring. All-in-one tool. http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
